Attention is currently required from: plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/873?usp=email )
Change subject: Print warnings/errors when numerical parameters cannot be parsed ...................................................................... Patch Set 2: Code-Review-1 (2 comments) Patchset: PS2: LGTM, but would be a good opportunity to move the code to options_util.c and add unittests? File src/openvpn/options.c: http://gerrit.openvpn.net/c/openvpn/+/873/comment/299b83cd_d792bac7 : PS1, Line 4939: if (i < 0 || endptr || i > INT_MAX) > Should probably be *endptr? Basically we want to check that it is \0, right? > […] Done -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/873?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: Ie1e2eb54d516b3ae87c5ca56fe8edd77ee2be4de Gerrit-Change-Number: 873 Gerrit-PatchSet: 2 Gerrit-Owner: plaisthos <arne-open...@rfc2549.org> Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com> Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net> Gerrit-Attention: plaisthos <arne-open...@rfc2549.org> Gerrit-Comment-Date: Tue, 21 Jan 2025 14:53:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: flichtenheld <fr...@lichtenheld.com> Gerrit-MessageType: comment
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
