Attention is currently required from: d12fk, plaisthos.

cron2 has posted comments on this change. ( 
http://gerrit.openvpn.net/c/openvpn/+/840?usp=email )

Change subject: dns: don't publish env vars to non-dns scripts
......................................................................


Patch Set 7:

(1 comment)

Patchset:

PS7:
That seems to be precisely the discussion we had in Karlsruhe - breaking 
existing script hooks just because the new approach is considered "better" is 
not going to make anyone happy.  So I'm fairly sure we decided that we do not 
want to do that, at least not for 2.7.0, not before users and distros have had 
a chance to adjust.

Also, whatever the server pushes (`dhcp-option dns` or `dns`) should populate 
the old options, for the same reason - otherwise moving the server to new-style 
options ("ah, the client sends IV_DNS") will break existing setups.



--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/840?usp=email
To unsubscribe, or for help writing mail filters, visit 
http://gerrit.openvpn.net/settings

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I3fb01ab76cf3df0874ba92e08f371d17607a8369
Gerrit-Change-Number: 840
Gerrit-PatchSet: 7
Gerrit-Owner: d12fk <he...@openvpn.net>
Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com>
Gerrit-Reviewer: plaisthos <arne-open...@rfc2549.org>
Gerrit-CC: cron2 <g...@greenie.muc.de>
Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net>
Gerrit-Attention: plaisthos <arne-open...@rfc2549.org>
Gerrit-Attention: d12fk <he...@openvpn.net>
Gerrit-Comment-Date: Tue, 21 Jan 2025 16:48:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Reply via email to