Attention is currently required from: d12fk, plaisthos. cron2 has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/840?usp=email )
The change is no longer submittable: Code-Review is unsatisfied now. Change subject: dns: don't publish env vars to non-dns scripts ...................................................................... Patch Set 12: Code-Review-2 (1 comment) Patchset: PS12: Not sure I understand this - isn't this exactly what we discussed in the meeting a week ago that we are not going to do, that is, "break --up scripts setting up DNS"? The suggested approach was - if --dns script is active (which is to be made a configure opt-in decision, so distributions can make it always-on and compile-yourself users can actively turn it on if they want it) *then* do not publish these env variables to --up - if --dns script is not active, leave --up scripts alone -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/840?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I3fb01ab76cf3df0874ba92e08f371d17607a8369 Gerrit-Change-Number: 840 Gerrit-PatchSet: 12 Gerrit-Owner: d12fk <he...@openvpn.net> Gerrit-Reviewer: cron2 <g...@greenie.muc.de> Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com> Gerrit-Reviewer: plaisthos <arne-open...@rfc2549.org> Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net> Gerrit-Attention: plaisthos <arne-open...@rfc2549.org> Gerrit-Attention: d12fk <he...@openvpn.net> Gerrit-Comment-Date: Sat, 08 Mar 2025 16:53:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
