Attention is currently required from: flichtenheld, ralf_lici. cron2 has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/831?usp=email )
Change subject: Handle missing DCO peer by restarting the session ...................................................................... Patch Set 1: Code-Review-1 (1 comment) Patchset: PS1: I can see what you are aiming for, but do not like the way this is done today - it's basically duplicating the same code + same message multiple times in otherwise not DCO related code. Can we print the message *inside* `dco_get_peer_stats()` (= one single place), to start with? And maybe some more clever way to register the `SIGUSR1`? -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/831?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: Ib118426c5a69256894040c69856a4003d9f4637c Gerrit-Change-Number: 831 Gerrit-PatchSet: 1 Gerrit-Owner: ralf_lici <r...@mandelbit.com> Gerrit-Reviewer: cron2 <g...@greenie.muc.de> Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com> Gerrit-Reviewer: plaisthos <arne-open...@rfc2549.org> Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net> Gerrit-Attention: flichtenheld <fr...@lichtenheld.com> Gerrit-Attention: ralf_lici <r...@mandelbit.com> Gerrit-Comment-Date: Thu, 23 Jan 2025 12:59:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
