Attention is currently required from: cron2, flichtenheld, plaisthos.

ralf_lici has posted comments on this change. ( 
http://gerrit.openvpn.net/c/openvpn/+/831?usp=email )

Change subject: Handle missing DCO peer by restarting the session
......................................................................


Patch Set 2:

(2 comments)

Patchset:

PS1:
> I can see what you are aiming for, but do not like the way this is done today 
> - it's basically dupli […]
As you suggested on irc I added a boolean parameter to 
dco_get_peer_stats(_multi)(). Anyway I'm not sure how can I raise the signal 
differently.


File src/openvpn/sig.c:

http://gerrit.openvpn.net/c/openvpn/+/831/comment/990397a3_da23205f :
PS1, Line 495:             msg(M_WARN, "Error requesting peer %d DCO stats 
(%s). Restarting the session",
> Might to give some user understandable reason/guidance. I would not know what 
> to expect here. […]
Done



--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/831?usp=email
To unsubscribe, or for help writing mail filters, visit 
http://gerrit.openvpn.net/settings

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Ib118426c5a69256894040c69856a4003d9f4637c
Gerrit-Change-Number: 831
Gerrit-PatchSet: 2
Gerrit-Owner: ralf_lici <r...@mandelbit.com>
Gerrit-Reviewer: cron2 <g...@greenie.muc.de>
Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com>
Gerrit-Reviewer: plaisthos <arne-open...@rfc2549.org>
Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net>
Gerrit-Attention: plaisthos <arne-open...@rfc2549.org>
Gerrit-Attention: cron2 <g...@greenie.muc.de>
Gerrit-Attention: flichtenheld <fr...@lichtenheld.com>
Gerrit-Comment-Date: Thu, 23 Jan 2025 16:50:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: plaisthos <arne-open...@rfc2549.org>
Comment-In-Reply-To: cron2 <g...@greenie.muc.de>
Gerrit-MessageType: comment
_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Reply via email to