Attention is currently required from: cron2, flichtenheld, ordex, plaisthos.
its_Giaan has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/765?usp=email ) Change subject: mroute: adapt to new protocol handling and hashing improvements ...................................................................... Patch Set 15: (7 comments) File src/openvpn/forward.c: http://gerrit.openvpn.net/c/openvpn/+/765/comment/7d7d6798_7dba137c : PS14, Line 1132: for (int i = 0; i < c->c1.link_sockets_num; i++) > I assume this hunk is needed, but it's sort of "outside the scope of mroute > handling" (so should eit […] This is still about client context, so no need to loop and no need to touch this again. http://gerrit.openvpn.net/c/openvpn/+/765/comment/4c321545_89555b0c : PS14, Line 1135: /* on the instance context we have only one socket, so just check the first one */ > whatever the outcome is, this comment is no longer correct :-) Done File src/openvpn/mroute.h: http://gerrit.openvpn.net/c/openvpn/+/765/comment/9bb3a8db_d8b619b4 : PS14, Line 225: return (uint32_t) a->len + 2; > if you change the start of the to-be-hashed block, but all the existing data > should still be hashed, […] Done File src/openvpn/mudp.c: http://gerrit.openvpn.net/c/openvpn/+/765/comment/ff1ec800_dab6a655 : PS14, Line 196: m->local.proto = real.proto; > This is a bit confusing. I can see the assignment to `real. […] That's a leftover, I see that m->local is used only on virtual addresses context so no need to copy the real proto and since it's CLEAR() no need to set the proto to 0. File src/openvpn/multi.c: http://gerrit.openvpn.net/c/openvpn/+/765/comment/f9fda981_a1023801 : PS14, Line 1156: struct mroute_addr *addr, > this looks wrong. A lookup function should not modify its arguments. […] Done http://gerrit.openvpn.net/c/openvpn/+/765/comment/285a38d0_93d7ac29 : PS14, Line 3356: > see comment above - now you're actually setting `proto` in the caller, even > if I do not agree this i […] Done http://gerrit.openvpn.net/c/openvpn/+/765/comment/9738102a_e71eb117 : PS14, Line 3561: dest.proto = src.proto; > same thing -> `mroute_extract_addr_from_packet()` Done -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/765?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: Ic66eccb5058fe9c0fae64d8e2ca88728068a92ab Gerrit-Change-Number: 765 Gerrit-PatchSet: 15 Gerrit-Owner: its_Giaan <gianma...@mandelbit.com> Gerrit-Reviewer: cron2 <g...@greenie.muc.de> Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com> Gerrit-Reviewer: plaisthos <arne-open...@rfc2549.org> Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net> Gerrit-CC: ordex <a...@unstable.cc> Gerrit-Attention: plaisthos <arne-open...@rfc2549.org> Gerrit-Attention: cron2 <g...@greenie.muc.de> Gerrit-Attention: flichtenheld <fr...@lichtenheld.com> Gerrit-Attention: ordex <a...@unstable.cc> Gerrit-Comment-Date: Fri, 24 Jan 2025 11:48:44 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: cron2 <g...@greenie.muc.de> Gerrit-MessageType: comment
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
