Attention is currently required from: flichtenheld, its_Giaan, ordex, plaisthos.
cron2 has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/765?usp=email ) Change subject: mroute: adapt to new protocol handling and hashing improvements ...................................................................... Patch Set 15: Code-Review-1 (3 comments) Patchset: PS15: Upgrade to -1 ;-) - mostly this is fine, but we still lost a "const" argument, and there is a spurious blank line removal File src/openvpn/multi.c: http://gerrit.openvpn.net/c/openvpn/+/765/comment/6724d969_5ff543ed : PS15, Line 3413: spurious deletion of this blank line? don't :-) http://gerrit.openvpn.net/c/openvpn/+/765/comment/ee36f236_30cdf224 : PS15, Line 1156: struct mroute_addr *addr, please bring the "const" back... -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/765?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: Ic66eccb5058fe9c0fae64d8e2ca88728068a92ab Gerrit-Change-Number: 765 Gerrit-PatchSet: 15 Gerrit-Owner: its_Giaan <[email protected]> Gerrit-Reviewer: cron2 <[email protected]> Gerrit-Reviewer: flichtenheld <[email protected]> Gerrit-Reviewer: plaisthos <[email protected]> Gerrit-CC: openvpn-devel <[email protected]> Gerrit-CC: ordex <[email protected]> Gerrit-Attention: plaisthos <[email protected]> Gerrit-Attention: its_Giaan <[email protected]> Gerrit-Attention: flichtenheld <[email protected]> Gerrit-Attention: ordex <[email protected]> Gerrit-Comment-Date: Fri, 24 Jan 2025 12:47:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
_______________________________________________ Openvpn-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openvpn-devel
