Attention is currently required from: plaisthos, stipa. ordex has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/814?usp=email )
Change subject: mudp.c: keep offset value when resetting buffer ...................................................................... Patch Set 12: (1 comment) File src/openvpn/mudp.c: http://gerrit.openvpn.net/c/openvpn/+/814/comment/ef68c003_57b839a6 : PS12, Line 58: ASSERT(buf_init(&c->c2.buffers->aux_buf, buf.offset)); under what circumstance do we expect this ASSERT to be triggered? I am always scared to introduce new ASSERTs because a temporary condition may lead the server to "assert-out" and this may not be nice. -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/814?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I145573555aaace5e94774b5f977d032d3747ed72 Gerrit-Change-Number: 814 Gerrit-PatchSet: 12 Gerrit-Owner: stipa <[email protected]> Gerrit-Reviewer: flichtenheld <[email protected]> Gerrit-Reviewer: plaisthos <[email protected]> Gerrit-CC: openvpn-devel <[email protected]> Gerrit-CC: ordex <[email protected]> Gerrit-Attention: plaisthos <[email protected]> Gerrit-Attention: stipa <[email protected]> Gerrit-Comment-Date: Thu, 30 Jan 2025 08:44:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
_______________________________________________ Openvpn-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openvpn-devel
