Attention is currently required from: ordex, plaisthos. stipa has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/814?usp=email )
Change subject: mudp.c: keep offset value when resetting buffer ...................................................................... Patch Set 12: (1 comment) File src/openvpn/mudp.c: http://gerrit.openvpn.net/c/openvpn/+/814/comment/5d94cc70_a4b520cc : PS12, Line 58: ASSERT(buf_init(&c->c2.buffers->aux_buf, buf.offset)); > under what circumstance do we expect this ASSERT to be triggered? […] buf_init() can in fail if there is not enough capacity, but it should not be the case. In fact, all buf_init() calls except one are wrapped into ASSERT. -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/814?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I145573555aaace5e94774b5f977d032d3747ed72 Gerrit-Change-Number: 814 Gerrit-PatchSet: 12 Gerrit-Owner: stipa <lstipa...@gmail.com> Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com> Gerrit-Reviewer: plaisthos <arne-open...@rfc2549.org> Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net> Gerrit-CC: ordex <a...@unstable.cc> Gerrit-Attention: plaisthos <arne-open...@rfc2549.org> Gerrit-Attention: ordex <a...@unstable.cc> Gerrit-Comment-Date: Thu, 30 Jan 2025 09:01:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: ordex <a...@unstable.cc> Gerrit-MessageType: comment
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
