Attention is currently required from: its_Giaan, ordex, plaisthos.

cron2 has posted comments on this change. ( 
http://gerrit.openvpn.net/c/openvpn/+/764?usp=email )

Change subject: Add support for simultaneous use of UDP and TCP sockets
......................................................................


Patch Set 19: Code-Review-1

(1 comment)

Patchset:

PS19:
I have not done a new round of review on the code yet, but tested it somewhat 
more in earnest :-)

Running well-behaved clients on multiple UDP and TCP ports in parallel (2 UDP, 
1 TCP, changing ports, pinging around) worked very nicely.

Then I went for the gremlins - lots of short-lived connections on randomized 
destionation ports, with 4 sockets bound (2 UDP, 2 TCP), and *boom* it asserts 
on me, after about 5 minutes of gremlin run time...

```
2025-02-18 17:20:55 us=391543 Connection Attempt Assertion failed at 
forward.c:1756 (link_socket_actual_defined(c->c2.to_link_addr))
```

this is with DCO on the server, but I do not think it makes a difference - most 
likely this is a race condition because these clients are extremely 
non-well-behaved, read, some are killed right after TCP connection, or in the 
middle of the TLS handshake.



--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/764?usp=email
To unsubscribe, or for help writing mail filters, visit 
http://gerrit.openvpn.net/settings

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I31bbf87e4e568021445c7512ecefadfd4a69b363
Gerrit-Change-Number: 764
Gerrit-PatchSet: 19
Gerrit-Owner: its_Giaan <gianma...@mandelbit.com>
Gerrit-Reviewer: cron2 <g...@greenie.muc.de>
Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com>
Gerrit-Reviewer: plaisthos <arne-open...@rfc2549.org>
Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net>
Gerrit-CC: ordex <a...@unstable.cc>
Gerrit-Attention: plaisthos <arne-open...@rfc2549.org>
Gerrit-Attention: its_Giaan <gianma...@mandelbit.com>
Gerrit-Attention: ordex <a...@unstable.cc>
Gerrit-Comment-Date: Tue, 18 Feb 2025 16:24:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Reply via email to