Attention is currently required from: flichtenheld, ordex, plaisthos, stipa.
d12fk has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/872?usp=email ) Change subject: Implement override-username ...................................................................... Patch Set 7: (4 comments) File doc/man-sections/server-options.rst: http://gerrit.openvpn.net/c/openvpn/+/872/comment/9a7933da_4ff68b99 : PS7, Line 94: ``--auth-token-user`` option and and an auth token that is valid for double "and" http://gerrit.openvpn.net/c/openvpn/+/872/comment/b02a4f12_acc29d26 : PS7, Line 437: Special care has to be taken both the initial username of the client and the taken <that> both http://gerrit.openvpn.net/c/openvpn/+/872/comment/65376b74_f7e706db : PS7, Line 438: overridden username are correctly handled when using ``--override-username`` handled correctly File src/openvpn/multi.c: http://gerrit.openvpn.net/c/openvpn/+/872/comment/c4a8aefa_ab36060b : PS7, Line 2692: && strcmp(multi->locked_username, options->override_username) != 0) Consider using streq() instead of strcmp() in the patchset for better readability. -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/872?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: Ia4095518d5e4447992a2974e0d7a159d79ba6b6f Gerrit-Change-Number: 872 Gerrit-PatchSet: 7 Gerrit-Owner: plaisthos <arne-open...@rfc2549.org> Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com> Gerrit-CC: d12fk <he...@openvpn.net> Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net> Gerrit-CC: ordex <a...@unstable.cc> Gerrit-CC: stipa <lstipa...@gmail.com> Gerrit-Attention: plaisthos <arne-open...@rfc2549.org> Gerrit-Attention: flichtenheld <fr...@lichtenheld.com> Gerrit-Attention: ordex <a...@unstable.cc> Gerrit-Attention: stipa <lstipa...@gmail.com> Gerrit-Comment-Date: Tue, 25 Feb 2025 16:33:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
