Attention is currently required from: flichtenheld, stipa. plaisthos has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/872?usp=email )
Change subject: Implement override-username ...................................................................... Patch Set 5: (2 comments) File src/openvpn/auth_token.c: http://gerrit.openvpn.net/c/openvpn/+/872/comment/00564507_9759870a : PS5, Line 333: > spurious newline Done File src/openvpn/push.c: http://gerrit.openvpn.net/c/openvpn/+/872/comment/2902ac35_5cb0e350 : PS5, Line 601: char *base64user; > shouldn't we initialize it to NULL? We initialise the struct and zero it. This is a common pattern in OpenVPN that we assume members to be either NULL or correctly set. -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/872?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: Ia4095518d5e4447992a2974e0d7a159d79ba6b6f Gerrit-Change-Number: 872 Gerrit-PatchSet: 5 Gerrit-Owner: plaisthos <arne-open...@rfc2549.org> Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com> Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net> Gerrit-CC: ordex <a...@unstable.cc> Gerrit-CC: stipa <lstipa...@gmail.com> Gerrit-Attention: flichtenheld <fr...@lichtenheld.com> Gerrit-Attention: stipa <lstipa...@gmail.com> Gerrit-Comment-Date: Mon, 17 Feb 2025 12:04:13 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: stipa <lstipa...@gmail.com> Gerrit-MessageType: comment
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
