Looking at this with "git show --color-moved=zebra -U20" makes clear that it's just moving around the call that could fail, and if it fails, do not modify anything else that might then become inconsistent. As far as I can see, nothing of this has side effects where order would be important (except when erroring-out, of course).
Your patch has been applied to the master branch. commit 7825a8c586a8beba209370f1594cd0987b653ab7 Author: Arne Schwabe Date: Thu Mar 27 16:36:00 2025 +0100 Do not leave half-initialised key wrap struct when dynamic tls-crypt fails Signed-off-by: Arne Schwabe <a...@rfc2549.org> Acked-by: MaxF <m...@max-fillinger.net> Message-Id: <20250327153606.15282-1-g...@greenie.muc.de> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg31267.html Signed-off-by: Gert Doering <g...@greenie.muc.de> -- kind regards, Gert Doering _______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel