Attention is currently required from: plaisthos, stipa.

d12fk has posted comments on this change. ( 
http://gerrit.openvpn.net/c/openvpn/+/837?usp=email )

Change subject: win: implement --dns option support with NRPT
......................................................................


Patch Set 16:

(1 comment)

File src/openvpnserv/interactive.c:

http://gerrit.openvpn.net/c/openvpn/+/837/comment/a8476c39_19850a6f :
PS15, Line 2187:         err = RegGetValueW(itf, NULL, values[i], 
RRF_RT_REG_SZ, NULL, (PBYTE)domains, size);
> For existing but empty values, the size will be set to 2. […]
Very nice find.



--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/837?usp=email
To unsubscribe, or for help writing mail filters, visit 
http://gerrit.openvpn.net/settings

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I576e74f3276362606e9cbd50bb5adbebaaf209cc
Gerrit-Change-Number: 837
Gerrit-PatchSet: 16
Gerrit-Owner: d12fk <he...@openvpn.net>
Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com>
Gerrit-Reviewer: plaisthos <arne-open...@rfc2549.org>
Gerrit-Reviewer: stipa <lstipa...@gmail.com>
Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net>
Gerrit-Attention: plaisthos <arne-open...@rfc2549.org>
Gerrit-Attention: stipa <lstipa...@gmail.com>
Gerrit-Comment-Date: Sat, 05 Apr 2025 04:11:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: stipa <lstipa...@gmail.com>
Gerrit-MessageType: comment
_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Reply via email to