Attention is currently required from: d12fk, plaisthos. stipa has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/837?usp=email )
Change subject: win: implement --dns option support with NRPT ...................................................................... Patch Set 18: Code-Review+2 (1 comment) Patchset: PS18: I couldn't find any more issues in the code, I tested it and it works like expected - I checked that the NRPT rules are created/removed and adapter-specific DNS suffixes are also respected in NRPT. Probably not directly related to this patch, but the behavior is now not according to man page. For example if server pushes push "dns server 1 resolve-domains fi" push "dns server 1 address 1.1.1.1" I would expect only .fi domains being resolved via 1.1.1.1, however ALL domains are resolved via 1.1.1.1 - this is likely because we set 1.1.1.1 DNS on VPN adapter. why we do it in addition to NRPT? We should either change the man page or fix the behavior. -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/837?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I576e74f3276362606e9cbd50bb5adbebaaf209cc Gerrit-Change-Number: 837 Gerrit-PatchSet: 18 Gerrit-Owner: d12fk <he...@openvpn.net> Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com> Gerrit-Reviewer: plaisthos <arne-open...@rfc2549.org> Gerrit-Reviewer: stipa <lstipa...@gmail.com> Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net> Gerrit-Attention: plaisthos <arne-open...@rfc2549.org> Gerrit-Attention: d12fk <he...@openvpn.net> Gerrit-Comment-Date: Wed, 09 Apr 2025 13:54:44 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
