Attention is currently required from: cron2, plaisthos.
Hello plaisthos,
I'd like you to do a code review.
Please visit
http://gerrit.openvpn.net/c/openvpn/+/930?usp=email
to review the following change.
Change subject: GHA: Pin version of CMake for MinGW build
......................................................................
GHA: Pin version of CMake for MinGW build
Turns out that "apt install cmake" is useless since
Github installs also CMake but not as a package. So
make sure we control which CMake we get and not
Github.
Switch to get-cmake action (which also installs ninja)
and remove the installation via apt.
Backport from master but much more limited since we
do not have Android nor AWS LC builds in release/2.6.
Change-Id: Ief11d5d7ccae084c863b50054d4e97c71f57d6f0
Signed-off-by: Frank Lichtenheld <[email protected]>
Acked-by: Gert Doering <[email protected]>
Message-Id: <[email protected]>
URL:
https://www.mail-archive.com/[email protected]/msg31299.html
Signed-off-by: Gert Doering <[email protected]>
(cherry picked from commit da65c4fdde20e36df38a90c1f1ef1d8ebf486c28)
---
M .github/workflows/build.yaml
1 file changed, 2 insertions(+), 1 deletion(-)
git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/30/930/1
diff --git a/.github/workflows/build.yaml b/.github/workflows/build.yaml
index 5b1c797..37ac6ec 100644
--- a/.github/workflows/build.yaml
+++ b/.github/workflows/build.yaml
@@ -47,10 +47,11 @@
VCPKG_ROOT: ${{ github.workspace }}/vcpkg
steps:
- name: Install dependencies
- run: sudo apt update && sudo apt install -y mingw-w64 unzip cmake
ninja-build build-essential wget python3-docutils man2html-base
+ run: sudo apt update && sudo apt install -y mingw-w64 unzip
build-essential wget python3-docutils man2html-base
- name: Checkout OpenVPN
uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 #
v4.2.2
+ - uses: lukka/get-cmake@56d043d188c3612951d8755da8f4b709ec951ad6 #
v3.31.6
- name: Restore from cache and install vcpkg
uses: lukka/run-vcpkg@5e0cab206a5ea620130caf672fce3e4a6b5666a1 # v11.5
with:
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/930?usp=email
To unsubscribe, or for help writing mail filters, visit
http://gerrit.openvpn.net/settings
Gerrit-Project: openvpn
Gerrit-Branch: release/2.6
Gerrit-Change-Id: Ief11d5d7ccae084c863b50054d4e97c71f57d6f0
Gerrit-Change-Number: 930
Gerrit-PatchSet: 1
Gerrit-Owner: flichtenheld <[email protected]>
Gerrit-Reviewer: cron2 <[email protected]>
Gerrit-Reviewer: plaisthos <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: plaisthos <[email protected]>
Gerrit-Attention: cron2 <[email protected]>
Gerrit-MessageType: newchange
_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
