Attention is currently required from: flichtenheld, plaisthos, stipa. cron2 has posted comments on this change by stipa. ( http://gerrit.openvpn.net/c/openvpn/+/903?usp=email )
Change subject: Make recursive routing check more fine-grained ...................................................................... Patch Set 3: Code-Review-1 (3 comments) Patchset: PS3: close :-) - one code rearrangement, one comment (in two places), then this can move on. I have tested it, and the main difference is "it logs more"... but with some policy routing twists, we could end up at a setup where it makes a difference. File src/openvpn/forward.c: http://gerrit.openvpn.net/c/openvpn/+/903/comment/72c2ad29_60c1bde2?usp=email : PS3, Line 1427: } This one should go up where it was, before the `openvpn_iphdr *pip` assignment (because we do not need to look for "proto" if we already know the AFI is different). For IPv6, the old order has been kept... http://gerrit.openvpn.net/c/openvpn/+/903/comment/18f831f2_47078c77?usp=email : PS3, Line 1432: uint16_t dst_port = ntohs(*(uint16_t *)(l4_hdr + sizeof(uint16_t))); while at it, maybe add a comment about "TCP and UDP ports are at the same place in the header, and other protocols can not happen here due to the lsi->proto check above"? Because my first thought was "why is he not using openvpn_tcphdr here?"... -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/903?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I6841e2f2a85275254a04e2d8ae3defe4420db8f6 Gerrit-Change-Number: 903 Gerrit-PatchSet: 3 Gerrit-Owner: stipa <lstipa...@gmail.com> Gerrit-Reviewer: cron2 <g...@greenie.muc.de> Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com> Gerrit-Reviewer: plaisthos <arne-open...@rfc2549.org> Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net> Gerrit-Attention: plaisthos <arne-open...@rfc2549.org> Gerrit-Attention: flichtenheld <fr...@lichtenheld.com> Gerrit-Attention: stipa <lstipa...@gmail.com> Gerrit-Comment-Date: Sat, 11 Oct 2025 11:01:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
