Attention is currently required from: flichtenheld, plaisthos.

stipa has posted comments on this change by stipa. ( 
http://gerrit.openvpn.net/c/openvpn/+/903?usp=email )

Change subject: Make recursive routing check more fine-grained
......................................................................


Patch Set 4:

(3 comments)

Patchset:

PS4:
Done!


File src/openvpn/forward.c:

http://gerrit.openvpn.net/c/openvpn/+/903/comment/c9143714_87c18b72?usp=email :
PS3, Line 1427:         }
> This one should go up where it was, before the `openvpn_iphdr *pip` 
> assignment (because we do not ne […]
Done


http://gerrit.openvpn.net/c/openvpn/+/903/comment/e5c4d8eb_9f9a10f0?usp=email :
PS3, Line 1432:         uint16_t dst_port = ntohs(*(uint16_t *)(l4_hdr + 
sizeof(uint16_t)));
> while at it, maybe add a comment about "TCP and UDP ports are at the same 
> place in the header, and o […]
Done



--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/903?usp=email
To unsubscribe, or for help writing mail filters, visit 
http://gerrit.openvpn.net/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I6841e2f2a85275254a04e2d8ae3defe4420db8f6
Gerrit-Change-Number: 903
Gerrit-PatchSet: 4
Gerrit-Owner: stipa <[email protected]>
Gerrit-Reviewer: cron2 <[email protected]>
Gerrit-Reviewer: flichtenheld <[email protected]>
Gerrit-Reviewer: plaisthos <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: plaisthos <[email protected]>
Gerrit-Attention: flichtenheld <[email protected]>
Gerrit-Comment-Date: Sat, 11 Oct 2025 11:44:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: cron2 <[email protected]>
_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Reply via email to