Attention is currently required from: flichtenheld, mrbff, ordex, plaisthos.
cron2 has posted comments on this change by mrbff. ( http://gerrit.openvpn.net/c/openvpn/+/1253?usp=email ) Change subject: PUSH_UPDATE server: remove old IP(s) from vhash after sending a message containing ifconfig(-ipv6) ...................................................................... Patch Set 7: Code-Review+2 (3 comments) Patchset: PS7: This looks good now. Tested a sequence of "change ifconfig, change ifconfig, change to -ifconfig, send new ifconfig" and it always learned/unlearned the expected things ``` Oct 17 22:11:37 gentoo tun-udp-p2mp[13761]: MULTI: Learn: 10.204.2.46 -> freebsd-14-amd64/udp6:194.97.140.5:60204 Oct 17 22:11:37 gentoo tun-udp-p2mp[13761]: MULTI: primary virtual IP for freebsd-14-amd64/udp6:194.97.140.5:60204: 10.204.2.46 Oct 17 22:11:37 gentoo tun-udp-p2mp[13761]: MULTI: Learn: fd00:abcd:204:2::100a -> freebsd-14-amd64/udp6:194.97.140.5:60204 Oct 17 22:11:37 gentoo tun-udp-p2mp[13761]: MULTI: primary virtual IPv6 for freebsd-14-amd64/udp6:194.97.140.5:60204: fd00:abcd:204:2::100a Oct 17 22:13:15 gentoo tun-udp-p2mp[13761]: MULTI: Unlearn: 10.204.2.46 -> freebsd-14-amd64/udp6:194.97.140.5:60204 Oct 17 22:13:15 gentoo tun-udp-p2mp[13761]: MULTI: Learn: 10.204.2.99 -> freebsd-14-amd64/udp6:194.97.140.5:60204 Oct 17 22:13:38 gentoo tun-udp-p2mp[13761]: MULTI: Unlearn: 10.204.2.99 -> freebsd-14-amd64/udp6:194.97.140.5:60204 Oct 17 22:13:38 gentoo tun-udp-p2mp[13761]: MULTI: Learn: 10.204.2.146 -> freebsd-14-amd64/udp6:194.97.140.5:60204 Oct 17 22:14:40 gentoo tun-udp-p2mp[13761]: MULTI: Unlearn: 10.204.2.146 -> freebsd-14-amd64/udp6:194.97.140.5:60204 Oct 17 22:14:57 gentoo tun-udp-p2mp[13761]: MULTI: Learn: 10.204.2.99 -> freebsd-14-amd64/udp6:194.97.140.5:60204 ``` also the logging is symmetric now (thanks again). Very nice. I also tested IPv6, though it mains me to send "PUSH_UPDATE,-ifconfig-ipv6" - but it still works :-) File src/openvpn/push_util.c: http://gerrit.openvpn.net/c/openvpn/+/1253/comment/831de5dd_a3d9baac?usp=email : PS6, Line 165: o.ifconfig_local = canary; > the canary is mostly to be less invasive as possible. […] Done http://gerrit.openvpn.net/c/openvpn/+/1253/comment/baeb5012_d8c04c16?usp=email : PS6, Line 166: o.ifconfig_ipv6_local = canary; > same for this obviously. While I agree that this is not pretty, I would still leave it at that (and mrbff admitted that "it is ugly"). I do like the rest of the code a lot in this latest iteration, and want to move it forward so it's in beta4... so I'm willing to accept this part of limited beauty. We can improve it later - right now it's "not working" which is definitely less useful ;-) -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1253?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I07a8ddd9026eef64b6f5abde98702a9801616a5f Gerrit-Change-Number: 1253 Gerrit-PatchSet: 7 Gerrit-Owner: mrbff <[email protected]> Gerrit-Reviewer: cron2 <[email protected]> Gerrit-Reviewer: flichtenheld <[email protected]> Gerrit-Reviewer: plaisthos <[email protected]> Gerrit-CC: openvpn-devel <[email protected]> Gerrit-CC: ordex <[email protected]> Gerrit-Attention: plaisthos <[email protected]> Gerrit-Attention: flichtenheld <[email protected]> Gerrit-Attention: ordex <[email protected]> Gerrit-Attention: mrbff <[email protected]> Gerrit-Comment-Date: Fri, 17 Oct 2025 20:18:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: ordex <[email protected]> Comment-In-Reply-To: mrbff <[email protected]>
_______________________________________________ Openvpn-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openvpn-devel
