Attention is currently required from: cron2, flichtenheld, mrbff, plaisthos.
ordex has posted comments on this change by mrbff. ( http://gerrit.openvpn.net/c/openvpn/+/1253?usp=email ) Change subject: PUSH_UPDATE server: remove old IP(s) from vhash after sending a message containing ifconfig(-ipv6) ...................................................................... Patch Set 6: (2 comments) File src/openvpn/push_util.c: http://gerrit.openvpn.net/c/openvpn/+/1253/comment/ffcc2b41_1a82ecae?usp=email : PS6, Line 165: o.ifconfig_local = canary; in other parts of the code we use having a bool named like `$option_defined` (in this case it would be `o.ifconfig_local_defined`) which is set to `true` when the option is present, but the value is ambiguous. May it make sense to do the same here instead of going the "canary" logic which would be unique to this piece of code? @[email protected] any opinion? http://gerrit.openvpn.net/c/openvpn/+/1253/comment/fdd76947_101b92fc?usp=email : PS6, Line 166: o.ifconfig_ipv6_local = canary; same for this obviously. -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1253?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I07a8ddd9026eef64b6f5abde98702a9801616a5f Gerrit-Change-Number: 1253 Gerrit-PatchSet: 6 Gerrit-Owner: mrbff <[email protected]> Gerrit-Reviewer: cron2 <[email protected]> Gerrit-Reviewer: flichtenheld <[email protected]> Gerrit-Reviewer: plaisthos <[email protected]> Gerrit-CC: openvpn-devel <[email protected]> Gerrit-CC: ordex <[email protected]> Gerrit-Attention: plaisthos <[email protected]> Gerrit-Attention: cron2 <[email protected]> Gerrit-Attention: flichtenheld <[email protected]> Gerrit-Attention: mrbff <[email protected]> Gerrit-Comment-Date: Tue, 14 Oct 2025 12:31:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No
_______________________________________________ Openvpn-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openvpn-devel
