Attention is currently required from: plaisthos.
Hello plaisthos,
I'd like you to do a code review.
Please visit
http://gerrit.openvpn.net/c/openvpn/+/1393?usp=email
to review the following change.
Change subject: iservice: check for NULL pointer
......................................................................
iservice: check for NULL pointer
Check if the list argument to ListContainsDomain() is NULL. Otherwise
the call to wcsstr() will bail out.
Reported-by: Marc Heuse <[email protected]>
Reported-by: [email protected]
Change-Id: Icd7c7b08e317aefd91a60bfc62e92cd8707b6fac
Signed-off-by: Heiko Hund <[email protected]>
---
M src/openvpnserv/interactive.c
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/93/1393/1
diff --git a/src/openvpnserv/interactive.c b/src/openvpnserv/interactive.c
index ec80a30..006f748 100644
--- a/src/openvpnserv/interactive.c
+++ b/src/openvpnserv/interactive.c
@@ -2106,7 +2106,7 @@
ListContainsDomain(PCWSTR list, PCWSTR domain, size_t len)
{
PCWSTR match = list;
- while (TRUE)
+ while (match)
{
match = wcsstr(match, domain);
if (!match)
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1393?usp=email
To unsubscribe, or for help writing mail filters, visit
http://gerrit.openvpn.net/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Icd7c7b08e317aefd91a60bfc62e92cd8707b6fac
Gerrit-Change-Number: 1393
Gerrit-PatchSet: 1
Gerrit-Owner: d12fk <[email protected]>
Gerrit-Reviewer: plaisthos <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: plaisthos <[email protected]>
_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
