cron2 has submitted this change. ( http://gerrit.openvpn.net/c/openvpn/+/1393?usp=email )
Change subject: iservice: check for NULL pointer ...................................................................... iservice: check for NULL pointer Check if the list argument to ListContainsDomain() is NULL. Otherwise the call to wcsstr() will bail out. Reported-by: Marc Heuse <[email protected]> Reported-by: [email protected] Change-Id: Icd7c7b08e317aefd91a60bfc62e92cd8707b6fac Signed-off-by: Heiko Hund <[email protected]> Acked-by: Gert Doering <[email protected]> Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1393 Message-Id: <[email protected]> URL: https://www.mail-archive.com/[email protected]/msg34611.html Signed-off-by: Gert Doering <[email protected]> --- M src/openvpnserv/interactive.c 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/openvpnserv/interactive.c b/src/openvpnserv/interactive.c index 860375d..07ca7c9 100644 --- a/src/openvpnserv/interactive.c +++ b/src/openvpnserv/interactive.c @@ -2106,7 +2106,7 @@ ListContainsDomain(PCWSTR list, PCWSTR domain, size_t len) { PCWSTR match = list; - while (TRUE) + while (match) { match = wcsstr(match, domain); if (!match) -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1393?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: Icd7c7b08e317aefd91a60bfc62e92cd8707b6fac Gerrit-Change-Number: 1393 Gerrit-PatchSet: 2 Gerrit-Owner: d12fk <[email protected]> Gerrit-Reviewer: cron2 <[email protected]> Gerrit-Reviewer: plaisthos <[email protected]> Gerrit-CC: openvpn-devel <[email protected]>
_______________________________________________ Openvpn-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openvpn-devel
