Attention is currently required from: d12fk, plaisthos. cron2 has posted comments on this change by d12fk. ( http://gerrit.openvpn.net/c/openvpn/+/1391?usp=email )
Change subject: iservice: return correct size when domains are truncated ...................................................................... Patch Set 1: Code-Review-1 (2 comments) Patchset: PS1: I might not understand this, but we have `+ one_glyph` in one return branch, and `+ 1` in the other. This can't be both correct. File src/openvpnserv/interactive.c: http://gerrit.openvpn.net/c/openvpn/+/1391/comment/028ab026_9b0f67b5?usp=email : PS1, Line 2217: *size = converted_size == 0 ? 0 : converted_size + 1; `+1` or `+ one_glyph`? The code 10 lines up does ``` /* This was the last domain */ *pos = '\0'; *size += one_glyph; return wcslen(domains) ? NO_ERROR : ERROR_FILE_NOT_FOUND; ``` both can not be correct at the same time. -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1391?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: Iabad046c930dd0f38ec50d1c43d8b3288816df7d Gerrit-Change-Number: 1391 Gerrit-PatchSet: 1 Gerrit-Owner: d12fk <[email protected]> Gerrit-Reviewer: cron2 <[email protected]> Gerrit-Reviewer: plaisthos <[email protected]> Gerrit-CC: openvpn-devel <[email protected]> Gerrit-Attention: plaisthos <[email protected]> Gerrit-Attention: d12fk <[email protected]> Gerrit-Comment-Date: Sun, 23 Nov 2025 11:57:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes
_______________________________________________ Openvpn-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openvpn-devel
