Attention is currently required from: cron2, plaisthos. d12fk has posted comments on this change by d12fk. ( http://gerrit.openvpn.net/c/openvpn/+/1391?usp=email )
Change subject: iservice: return correct size when domains are truncated ...................................................................... Patch Set 2: (1 comment) File src/openvpnserv/interactive.c: http://gerrit.openvpn.net/c/openvpn/+/1391/comment/bf8a5953_96e69ead?usp=email : PS1, Line 2217: *size = converted_size == 0 ? 0 : converted_size + 1; > `+1` or `+ one_glyph`? […] The longer I stare at the code, the less I like `one_glyph` as a name, will change it to `glyph_size` to make more sense. Patch on top follows. -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1391?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: Iabad046c930dd0f38ec50d1c43d8b3288816df7d Gerrit-Change-Number: 1391 Gerrit-PatchSet: 2 Gerrit-Owner: d12fk <[email protected]> Gerrit-Reviewer: cron2 <[email protected]> Gerrit-Reviewer: plaisthos <[email protected]> Gerrit-CC: openvpn-devel <[email protected]> Gerrit-Attention: plaisthos <[email protected]> Gerrit-Attention: cron2 <[email protected]> Gerrit-Comment-Date: Sun, 23 Nov 2025 19:55:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: cron2 <[email protected]>
_______________________________________________ Openvpn-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openvpn-devel
