Attention is currently required from: plaisthos.

Hello plaisthos,

I'd like you to do a code review.
Please visit

    http://gerrit.openvpn.net/c/openvpn/+/1406?usp=email

to review the following change.


Change subject: Properly log peer-id in P2P mode
......................................................................

Properly log peer-id in P2P mode

As of now OpenVPN prints o->peer_id in the deferred
options log message, however in P2P mode that field
is currently always 0 as it gets populated only when
a peer-id is pushed by a server (which doesn't happen in P2P).

Fix this by populate o->peer_id before loggin it.

Change-Id: I80aed8a91259374d4b2b2155a8f47e286f2def75
Signed-off-by: Gianmarco De Gregori <[email protected]>
---
M src/openvpn/init.c
1 file changed, 1 insertion(+), 0 deletions(-)



  git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/06/1406/1

diff --git a/src/openvpn/init.c b/src/openvpn/init.c
index fc079e1..b7795c7 100644
--- a/src/openvpn/init.c
+++ b/src/openvpn/init.c
@@ -2541,6 +2541,7 @@
     }

     c->options.use_peer_id = c->c2.tls_multi->use_peer_id;
+    c->options.peer_id = c->c2.tls_multi->peer_id;

     struct tls_session *session = &c->c2.tls_multi->session[TM_ACTIVE];


--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1406?usp=email
To unsubscribe, or for help writing mail filters, visit 
http://gerrit.openvpn.net/settings?usp=email

Gerrit-MessageType: newchange
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I80aed8a91259374d4b2b2155a8f47e286f2def75
Gerrit-Change-Number: 1406
Gerrit-PatchSet: 1
Gerrit-Owner: its_Giaan <[email protected]>
Gerrit-Reviewer: plaisthos <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: plaisthos <[email protected]>
_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Reply via email to