Attention is currently required from: plaisthos.

its_Giaan has posted comments on this change by its_Giaan. ( 
http://gerrit.openvpn.net/c/openvpn/+/1406?usp=email )

Change subject: Properly log peer-id in P2P mode
......................................................................


Patch Set 1:

(1 comment)

File src/openvpn/init.c:

http://gerrit.openvpn.net/c/openvpn/+/1406/comment/1cdc608c_a8b77cad?usp=email :
PS1, Line 2544:     c->options.peer_id = c->c2.tls_multi->peer_id;
> I feel this the wrong fix. […]
Yeah I strongly agree, and we indeed look for options->peer_id in 
tls_print_deferred_options_results() in fact in the asym-peer-id patch I've 
arbitrary switched to tls_multi->peer_id, so if we're fine with that I will do 
the same, but as you can see the tls_print_deferred_options_results() talks 
about options so not sure.



--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1406?usp=email
To unsubscribe, or for help writing mail filters, visit 
http://gerrit.openvpn.net/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I80aed8a91259374d4b2b2155a8f47e286f2def75
Gerrit-Change-Number: 1406
Gerrit-PatchSet: 1
Gerrit-Owner: its_Giaan <[email protected]>
Gerrit-Reviewer: plaisthos <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: plaisthos <[email protected]>
Gerrit-Comment-Date: Wed, 26 Nov 2025 21:12:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: plaisthos <[email protected]>
_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Reply via email to