Hi,
so, I wanted to merge this into 2.7_rc4 ("it has an ACK, it has unit tests")
but there is one hunk I do not understand...
On Mon, Dec 01, 2025 at 03:04:18PM +0100, Moritz Fain wrote:
> diff --git a/src/openvpn/push.c b/src/openvpn/push.c
> index 7852d360..898d1585 100644
> --- a/src/openvpn/push.c
> +++ b/src/openvpn/push.c
> @@ -540,11 +540,15 @@ incoming_push_message(struct context *c, const
> struct buffer *buffer)
> }
> else
> {
> - if (!option_types_found)
> + /* Clear push_update_options_found for next
> PUSH_UPDATE sequence */
> + c->options.push_update_options_found = 0;
> +
> + /* Use accumulated option_types_found for the entire
> PUSH_UPDATE sequence */
> + if (!c->options.push_option_types_found)
> {
so... "we set push_update_options_found = 0, and then we check if
it might be non-0"?
This looks wrong :-)
(Also, that hunk displays a problem of the sending mail client - it
wraps all long lines, so I had to manually unwrap ~30 lines, which is
stupid work that should be left to machines... so if at all possible,
please send patches with "git send-email" - this is magic, and succeeds
almost always in making patches arrive intact)
gert
--
"If was one thing all people took for granted, was conviction that if you
feed honest figures into a computer, honest figures come out. Never doubted
it myself till I met a computer with a sense of humor."
Robert A. Heinlein, The Moon is a Harsh Mistress
Gert Doering - Munich, Germany [email protected]
signature.asc
Description: PGP signature
_______________________________________________ Openvpn-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openvpn-devel
