So, after a bit of work, this is now in - always remember to use
"git send-email" to send patches to the list (or use gerrit), as normal
e-mail clients tend to line-wrap things. So about 30 lines in the patch
were wrapped, needing manual repair...
I have not explicitly tested this with a server-triggered PUSH_UPDATE
command ("no infrastructure yet"), but it does pass the unit test - thanks
for that addition - and the explanation & code make sense (arguably the
change to update_option() is not really necessary - one could just pass
in a pointer to o->push_update_options_found - but given that this is
not code where "keep branches similar" is relevant it does not make
a big difference either way).
Also, Marco has ACKed this, and it's his code ;-)
Your patch has been applied to the master branch.
commit d3c7d6cf560e52f8951c70abf05bd4151a29e0ff
Author: Moritz Fain
Date: Mon Dec 1 15:04:18 2025 +0100
PUSH_UPDATE: fix option reset logic in continuation messages
Acked-by: Marco Baffo <[email protected]>
Message-Id:
<CAM8w-qEE6vHj=yUOpTFbM7DqPKzUV0NupvEG4rUefY=knb2...@mail.gmail.com>
URL:
https://www.mail-archive.com/[email protected]/msg34814.html
Signed-off-by: Gert Doering <[email protected]>
--
kind regards,
Gert Doering
_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
