Attention is currently required from: flichtenheld, plaisthos. mandree has posted comments on this change by flichtenheld. ( http://gerrit.openvpn.net/c/openvpn/+/1445?usp=email )
Change subject: ssl_verify_openssl: Avoid conversion warning in x509_verify_cert_ku ...................................................................... Patch Set 1: Code-Review-2 (5 comments) Patchset: PS1: I think the fixes go in the wrong direction. File src/openvpn/ssl_verify_openssl.c: http://gerrit.openvpn.net/c/openvpn/+/1445/comment/821e73fa_f775f9c3?usp=email : PS1, Line 678: x509_verify_cert_ku(X509 *x509, const unsigned *const expected_ku, int expected_len) expected_len might be an unsigned int or size_t to fix warnings below. http://gerrit.openvpn.net/c/openvpn/+/1445/comment/d6e1387e_3213e9eb?usp=email : PS1, Line 696: for (int i = 0; i < 8; i++) I don't seem to have the ASN1_BIT_STRING_get_bit() manpage handy, but if the compiler is unhappy about the nku |= line, make the literals unsigned, as in nku |= 1u << (7u - i) while i is some unsigned type (such as size_t). http://gerrit.openvpn.net/c/openvpn/+/1445/comment/253f9ee2_e2908373?usp=email : PS1, Line 714: for (int i = 0; fFound != SUCCESS && i < expected_len; i++) If this triggers a signed/unsigned mismatch on the < - that's because the iterator was a size_t and the expected_len argument a signed plain "int". http://gerrit.openvpn.net/c/openvpn/+/1445/comment/360f53ad_26945225?usp=email : PS1, Line 725: for (int i = 0; i < expected_len && expected_ku[i]; i++) If this triggers a signed/unsigned mismatch on the < - that's because the iterator was a size_t and the expected_len argument a signed plain "int". -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1445?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: Ia6c3f0395bd6cd67064fe77420d9df2b66763049 Gerrit-Change-Number: 1445 Gerrit-PatchSet: 1 Gerrit-Owner: flichtenheld <[email protected]> Gerrit-Reviewer: mandree <[email protected]> Gerrit-Reviewer: plaisthos <[email protected]> Gerrit-CC: openvpn-devel <[email protected]> Gerrit-Attention: plaisthos <[email protected]> Gerrit-Attention: flichtenheld <[email protected]> Gerrit-Comment-Date: Tue, 16 Dec 2025 19:41:00 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes
_______________________________________________ Openvpn-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openvpn-devel
