Attention is currently required from: flichtenheld, plaisthos.

mandree has posted comments on this change by flichtenheld. ( 
http://gerrit.openvpn.net/c/openvpn/+/1445?usp=email )

Change subject: ssl_verify_openssl: Avoid conversion warning in 
x509_verify_cert_ku
......................................................................


Patch Set 1:

(1 comment)

File src/openvpn/ssl_verify_openssl.c:

http://gerrit.openvpn.net/c/openvpn/+/1445/comment/c27d7464_b4c44732?usp=email :
PS1, Line 696:     for (int i = 0; i < 8; i++)
> I don't seem to have the ASN1_BIT_STRING_get_bit() manpage handy, but if the 
> compiler is unhappy about the nku |= line, make the literals unsigned, as in 
> nku |= 1u << (7u - i) while i is some unsigned type (such as size_t).
So the 2nd argument to ASN1_BIT_STRING_get_bit() wants to be a literal "int" so 
this one change in the "for" would be OK.



--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1445?usp=email
To unsubscribe, or for help writing mail filters, visit 
http://gerrit.openvpn.net/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Ia6c3f0395bd6cd67064fe77420d9df2b66763049
Gerrit-Change-Number: 1445
Gerrit-PatchSet: 1
Gerrit-Owner: flichtenheld <[email protected]>
Gerrit-Reviewer: mandree <[email protected]>
Gerrit-Reviewer: plaisthos <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: plaisthos <[email protected]>
Gerrit-Attention: flichtenheld <[email protected]>
Gerrit-Comment-Date: Tue, 16 Dec 2025 19:46:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: mandree <[email protected]>
_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Reply via email to