Attention is currently required from: MaxF, cron2, plaisthos. flichtenheld has posted comments on this change by plaisthos. ( http://gerrit.openvpn.net/c/openvpn/+/1435?usp=email )
Change subject: Allow test-crypto to work without the --secret argument ...................................................................... Patch Set 7: Code-Review+2 (1 comment) File src/openvpn/options.c: http://gerrit.openvpn.net/c/openvpn/+/1435/comment/76bfcbc2_b234d8c7?usp=email : PS5, Line 2695: if (options->tls_server + options->tls_client + (options->shared_secret_file != NULL) > 1) > I think if we do that we should add it for all the "standalone" keys like > genkey, show-ciphers, show […] I'm okay with moving this change to a separate patch. It is not strictly required. -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1435?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I72947bd4f0213fd118327f740daeb1d86ae166de Gerrit-Change-Number: 1435 Gerrit-PatchSet: 7 Gerrit-Owner: plaisthos <[email protected]> Gerrit-Reviewer: MaxF <[email protected]> Gerrit-Reviewer: cron2 <[email protected]> Gerrit-Reviewer: flichtenheld <[email protected]> Gerrit-CC: openvpn-devel <[email protected]> Gerrit-Attention: plaisthos <[email protected]> Gerrit-Attention: cron2 <[email protected]> Gerrit-Attention: MaxF <[email protected]> Gerrit-Comment-Date: Thu, 18 Dec 2025 16:25:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: plaisthos <[email protected]> Comment-In-Reply-To: flichtenheld <[email protected]>
_______________________________________________ Openvpn-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openvpn-devel
