Attention is currently required from: plaisthos.
Hello plaisthos,
I'd like you to do a code review.
Please visit
http://gerrit.openvpn.net/c/openvpn/+/1466?usp=email
to review the following change.
Change subject: socks: Fix wrong success check in socks_username_password_auth
......................................................................
socks: Fix wrong success check in socks_username_password_auth
Due to wrong boolean operator the function did not
correctly detect when the authentication failed.
Reported-By: Joshua Rogers <[email protected]>
Found-By: ZeroPath (https://zeropath.com)
Github: openvpn-private-issues#4
Change-Id: I13b411fb3e8b913ae049c6ca8a1cf5a2edbab0fb
Signed-off-by: Frank Lichtenheld <[email protected]>
---
M src/openvpn/socks.c
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/66/1466/1
diff --git a/src/openvpn/socks.c b/src/openvpn/socks.c
index ed2d9e9..1e99c9a 100644
--- a/src/openvpn/socks.c
+++ b/src/openvpn/socks.c
@@ -143,7 +143,7 @@
}
/* VER = 5, SUCCESS = 0 --> auth success */
- if (buf[0] != 5 && buf[1] != 0)
+ if (buf[0] != 5 || buf[1] != 0)
{
msg(D_LINK_ERRORS, "socks_username_password_auth: server refused the
authentication");
goto cleanup;
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1466?usp=email
To unsubscribe, or for help writing mail filters, visit
http://gerrit.openvpn.net/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I13b411fb3e8b913ae049c6ca8a1cf5a2edbab0fb
Gerrit-Change-Number: 1466
Gerrit-PatchSet: 1
Gerrit-Owner: flichtenheld <[email protected]>
Gerrit-Reviewer: plaisthos <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: plaisthos <[email protected]>
_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
