cron2 has submitted this change. ( http://gerrit.openvpn.net/c/openvpn/+/1466?usp=email )
Change subject: socks: Fix wrong success check in socks_username_password_auth ...................................................................... socks: Fix wrong success check in socks_username_password_auth Due to wrong boolean operator the function did not correctly detect when the authentication failed. Reported-By: Joshua Rogers <[email protected]> Found-By: ZeroPath (https://zeropath.com) Github: openvpn-private-issues#4 Change-Id: I13b411fb3e8b913ae049c6ca8a1cf5a2edbab0fb Signed-off-by: Frank Lichtenheld <[email protected]> Acked-by: Gert Doering <[email protected]> Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1466 Message-Id: <[email protected]> URL: https://www.mail-archive.com/[email protected]/msg35219.html Signed-off-by: Gert Doering <[email protected]> --- M src/openvpn/socks.c 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/openvpn/socks.c b/src/openvpn/socks.c index 671d33c..078b4e1 100644 --- a/src/openvpn/socks.c +++ b/src/openvpn/socks.c @@ -143,7 +143,7 @@ } /* VER = 5, SUCCESS = 0 --> auth success */ - if (buf[0] != 5 && buf[1] != 0) + if (buf[0] != 5 || buf[1] != 0) { msg(D_LINK_ERRORS, "socks_username_password_auth: server refused the authentication"); goto cleanup; -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1466?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I13b411fb3e8b913ae049c6ca8a1cf5a2edbab0fb Gerrit-Change-Number: 1466 Gerrit-PatchSet: 2 Gerrit-Owner: flichtenheld <[email protected]> Gerrit-Reviewer: cron2 <[email protected]> Gerrit-Reviewer: plaisthos <[email protected]> Gerrit-CC: openvpn-devel <[email protected]>
_______________________________________________ Openvpn-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openvpn-devel
