Attention is currently required from: cron2, plaisthos. flichtenheld has posted comments on this change by flichtenheld. ( http://gerrit.openvpn.net/c/openvpn/+/1485?usp=email )
Change subject: status: Avoid conversion warnings in status_read/status_printf ...................................................................... Patch Set 2: (1 comment) File src/openvpn/status.c: http://gerrit.openvpn.net/c/openvpn/+/1485/comment/9696cdac_b218c0bb?usp=email : PS2, Line 241: if (write(so->fd, buf, (unsigned int)len) != len) > this change confuses me. […] This is required for Windows (see https://learn.microsoft.com/en-us/cpp/c-runtime-library/reference/write?view=msvc-170) In some of the places we have comments that this is for Windows (e.g. in test_ssl.c). Shall I add one here as well? -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1485?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: Iff1343a2f8cc7e32b8f36b359a00248e4dc3e8c9 Gerrit-Change-Number: 1485 Gerrit-PatchSet: 2 Gerrit-Owner: flichtenheld <[email protected]> Gerrit-Reviewer: cron2 <[email protected]> Gerrit-Reviewer: plaisthos <[email protected]> Gerrit-CC: openvpn-devel <[email protected]> Gerrit-Attention: plaisthos <[email protected]> Gerrit-Attention: cron2 <[email protected]> Gerrit-Comment-Date: Mon, 26 Jan 2026 12:47:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: cron2 <[email protected]>
_______________________________________________ Openvpn-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openvpn-devel
