Attention is currently required from: plaisthos. ordex has posted comments on this change by plaisthos. ( http://gerrit.openvpn.net/c/openvpn/+/1547?usp=email )
Change subject: Fix setting DCO ifmode failing on big endian archs ...................................................................... Patch Set 1: (1 comment) File src/openvpn/networking_sitnl.c: http://gerrit.openvpn.net/c/openvpn/+/1547/comment/aafb395a_49dc4aa8?usp=email : PS1, Line 1342: * other than uint8_t here causes the values to be 0 when passed maybe you can mention that the enum is probably wending up being a uint16 or uint32? Because you are implying that, but this detail is actually the crux of the issue. In a few months from now we may not remember anymore. What you are mentioning in this comment is just how endianess works (it can stay if you like it) -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1547?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I560f45fb0011180be8ca2b0e7fbc63030fa10f35 Gerrit-Change-Number: 1547 Gerrit-PatchSet: 1 Gerrit-Owner: plaisthos <[email protected]> Gerrit-Reviewer: ordex <[email protected]> Gerrit-CC: openvpn-devel <[email protected]> Gerrit-Attention: plaisthos <[email protected]> Gerrit-Comment-Date: Wed, 18 Feb 2026 19:44:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No
_______________________________________________ Openvpn-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openvpn-devel
