Attention is currently required from: plaisthos.

ralf_lici has posted comments on this change by plaisthos. ( 
http://gerrit.openvpn.net/c/openvpn/+/1547?usp=email )

Change subject: Fix setting DCO ifmode failing on big endian archs
......................................................................


Patch Set 1: Code-Review+2

(1 comment)

Patchset:

PS1:
The patch looks good to me and it fixes the issue. However, I wonder if there 
is a more systematic way to prevent this class of bugs in the future, possibly 
in SITNL_ADDATTR.

nit: "architcutre" typ0 in the commit body



--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1547?usp=email
To unsubscribe, or for help writing mail filters, visit 
http://gerrit.openvpn.net/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I560f45fb0011180be8ca2b0e7fbc63030fa10f35
Gerrit-Change-Number: 1547
Gerrit-PatchSet: 1
Gerrit-Owner: plaisthos <[email protected]>
Gerrit-Reviewer: ordex <[email protected]>
Gerrit-Reviewer: ralf_lici <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: plaisthos <[email protected]>
Gerrit-Comment-Date: Thu, 19 Feb 2026 07:47:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Reply via email to