Attention is currently required from: its_Giaan, plaisthos. flichtenheld has posted comments on this change by its_Giaan. ( http://gerrit.openvpn.net/c/openvpn/+/1521?usp=email )
Change subject: Add support for user defined network namespace ...................................................................... Patch Set 2: Code-Review-2 (6 comments) File src/openvpn/networking_sitnl.h: http://gerrit.openvpn.net/c/openvpn/+/1521/comment/bb1d8a23_20125c14?usp=email : PS1, Line 98: int openvpn_if_nametoindex(const char *ifname, int netnsid); > I'm not thrilled by the idea of having a function that does too much stuff so > I only moved the call […] Done File src/openvpn/networking_sitnl.c: http://gerrit.openvpn.net/c/openvpn/+/1521/comment/6558e3ae_b6c53a15?usp=email : PS1, Line 841: goto err; > M_ERRNO? This changes it from effectively `M_FATAL | M_ERRNO` to `M_INFO | M_ERRNO`. That feels like a big change. If you want the error to be fatal, then just remove the code after the msg() call. If you do not want it to be fatal, then use `M_WARN | M_ERRNO`. `M_INFO` feels wrong. http://gerrit.openvpn.net/c/openvpn/+/1521/comment/6bd42df7_ac3131a1?usp=email : PS1, Line 1002: err: > SITNL_ADDATTR() requires a label Acknowledged http://gerrit.openvpn.net/c/openvpn/+/1521/comment/623af649_3ec0329e?usp=email : PS1, Line 1124: err: > SITNL_ADDATTR() requires a label Acknowledged http://gerrit.openvpn.net/c/openvpn/+/1521/comment/3c69f209_c727ee44?usp=email : PS1, Line 1903: return netnsid; > Addressed in http://gerrit.openvpn. […] Done File src/openvpn/networking_sitnl.c: http://gerrit.openvpn.net/c/openvpn/+/1521/comment/8758f6bd_4e04d658?usp=email : PS2, Line 206: msg(M_ERRNO, "%s: Network namespace %s does not exist\n", __func__, path); Hmm, why did you change `M_WARN` to `M_ERRNO`? That means the same as `M_INFO | M_ERRNO` AFAICT. So I would have expected you to retain the `M_WARN`. `M_ERRNO` is not a level but an additional flag that ensures that strerr output is appended. -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1521?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I8b0d1cad7062856abcc40c4e16ec93b45295bbd3 Gerrit-Change-Number: 1521 Gerrit-PatchSet: 2 Gerrit-Owner: its_Giaan <[email protected]> Gerrit-Reviewer: flichtenheld <[email protected]> Gerrit-Reviewer: plaisthos <[email protected]> Gerrit-CC: openvpn-devel <[email protected]> Gerrit-Attention: plaisthos <[email protected]> Gerrit-Attention: its_Giaan <[email protected]> Gerrit-Comment-Date: Thu, 26 Feb 2026 11:37:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: its_Giaan <[email protected]> Comment-In-Reply-To: flichtenheld <[email protected]>
_______________________________________________ Openvpn-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openvpn-devel
