Attention is currently required from: flichtenheld, plaisthos.

its_Giaan has posted comments on this change by its_Giaan. ( 
http://gerrit.openvpn.net/c/openvpn/+/1521?usp=email )

Change subject: Add support for user defined network namespace
......................................................................


Patch Set 3:

(3 comments)

File src/openvpn/networking_sitnl.c:

http://gerrit.openvpn.net/c/openvpn/+/1521/comment/122e5461_ae4d3b5a?usp=email :
PS1, Line 841:         goto err;
> This changes it from effectively `M_FATAL | M_ERRNO` to `M_INFO | M_ERRNO`. 
> […]
Done


http://gerrit.openvpn.net/c/openvpn/+/1521/comment/05bd4cdb_f0807205?usp=email :
PS1, Line 848:         goto err;
> M_ERRNO?
Done


File src/openvpn/networking_sitnl.c:

http://gerrit.openvpn.net/c/openvpn/+/1521/comment/a653993b_b8776da3?usp=email :
PS2, Line 206:             msg(M_ERRNO, "%s: Network namespace %s does not 
exist\n", __func__, path);
> Hmm, why did you change `M_WARN` to `M_ERRNO`? That means the same as `M_INFO 
> | M_ERRNO` AFAICT. […]
Done



--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1521?usp=email
To unsubscribe, or for help writing mail filters, visit 
http://gerrit.openvpn.net/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I8b0d1cad7062856abcc40c4e16ec93b45295bbd3
Gerrit-Change-Number: 1521
Gerrit-PatchSet: 3
Gerrit-Owner: its_Giaan <[email protected]>
Gerrit-Reviewer: flichtenheld <[email protected]>
Gerrit-Reviewer: plaisthos <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: plaisthos <[email protected]>
Gerrit-Attention: flichtenheld <[email protected]>
Gerrit-Comment-Date: Thu, 26 Feb 2026 13:39:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: its_Giaan <[email protected]>
Comment-In-Reply-To: flichtenheld <[email protected]>
_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Reply via email to