Attention is currently required from: plaisthos.
Hello plaisthos,
I'd like you to do a code review.
Please visit
http://gerrit.openvpn.net/c/openvpn/+/1668?usp=email
to review the following change.
Change subject: route: Clarify operator precedence in a & b ? c : d
......................................................................
route: Clarify operator precedence in a & b ? c : d
As suggested by cppcheck.
Change-Id: I5c9b54dca0a14688a3bb7798cb086f5bde7311b8
Signed-off-by: Frank Lichtenheld <[email protected]>
---
M src/openvpn/route.c
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/68/1668/1
diff --git a/src/openvpn/route.c b/src/openvpn/route.c
index 3b18f74..0c88d57 100644
--- a/src/openvpn/route.c
+++ b/src/openvpn/route.c
@@ -2884,7 +2884,7 @@
.prefix.ipv4.s_addr = htonl(r->network),
.gateway.ipv4.s_addr = htonl(r->gateway),
.iface = { .index = if_index, .name = "" },
- .metric = (r->flags & RT_METRIC_DEFINED ?
r->metric : -1) };
+ .metric = ((r->flags & RT_METRIC_DEFINED) ?
r->metric : -1) };
netmask_to_netbits(r->network, r->netmask, &msg.prefix_len);
if (msg.prefix_len == -1)
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1668?usp=email
To unsubscribe, or for help writing mail filters, visit
http://gerrit.openvpn.net/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I5c9b54dca0a14688a3bb7798cb086f5bde7311b8
Gerrit-Change-Number: 1668
Gerrit-PatchSet: 1
Gerrit-Owner: flichtenheld <[email protected]>
Gerrit-Reviewer: plaisthos <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: plaisthos <[email protected]>
_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
