Attention is currently required from: flichtenheld, plaisthos. cron2 has posted comments on this change by flichtenheld. ( http://gerrit.openvpn.net/c/openvpn/+/1668?usp=email )
Change subject: route: Clarify operator precedence in a & b ? c : d ...................................................................... Patch Set 1: Code-Review-1 (1 comment) File src/openvpn/route.c: http://gerrit.openvpn.net/c/openvpn/+/1668/comment/7004e626_e74dcd6c?usp=email : PS1, Line 2887: .metric = ((r->flags & RT_METRIC_DEFINED) ? r->metric : -1) }; can we get rid of the outer braces? .metric = ( a & b )? c: d is clear enough to readers (IMHO easier to grasp) and should be fine for the compiler? -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1668?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I5c9b54dca0a14688a3bb7798cb086f5bde7311b8 Gerrit-Change-Number: 1668 Gerrit-PatchSet: 1 Gerrit-Owner: flichtenheld <[email protected]> Gerrit-Reviewer: cron2 <[email protected]> Gerrit-Reviewer: plaisthos <[email protected]> Gerrit-CC: openvpn-devel <[email protected]> Gerrit-Attention: plaisthos <[email protected]> Gerrit-Attention: flichtenheld <[email protected]> Gerrit-Comment-Date: Thu, 07 May 2026 05:49:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes
_______________________________________________ Openvpn-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openvpn-devel
