Attention is currently required from: plaisthos.
Hello plaisthos,
I'd like you to do a code review.
Please visit
http://gerrit.openvpn.net/c/openvpn/+/1672?usp=email
to review the following change.
Change subject: Fix some msg() calls with wrong number of arguments in
Windows-only code
......................................................................
Fix some msg() calls with wrong number of arguments in Windows-only code
For some reason neither MSVC nor MinGW complained?
cppcheck did (once told that msg is a printf-style
function).
Change-Id: Ia688ec12e642de699811ced8668b40be9fbb6155
Signed-off-by: Frank Lichtenheld <[email protected]>
---
M src/openvpnmsica/msiex.c
M src/tapctl/tap.c
2 files changed, 3 insertions(+), 3 deletions(-)
git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/72/1672/1
diff --git a/src/openvpnmsica/msiex.c b/src/openvpnmsica/msiex.c
index f8bf6ae..4d48f06 100644
--- a/src/openvpnmsica/msiex.c
+++ b/src/openvpnmsica/msiex.c
@@ -51,7 +51,7 @@
*pszValue = (LPWSTR)malloc(++dwLength * sizeof(WCHAR));
if (*pszValue == NULL)
{
- msg(M_FATAL, "%s: malloc(%u) failed", dwLength * sizeof(WCHAR));
+ msg(M_FATAL, "%s: malloc(%u) failed", __FUNCTION__, dwLength *
sizeof(WCHAR));
return ERROR_OUTOFMEMORY;
}
diff --git a/src/tapctl/tap.c b/src/tapctl/tap.c
index 6ed395d..cccc0e1 100644
--- a/src/tapctl/tap.c
+++ b/src/tapctl/tap.c
@@ -487,8 +487,8 @@
}
default:
- msg(M_NONFATAL, "%s: \"%ls\" registry value is not string (type
%u)", __FUNCTION__,
- dwValueType);
+ msg(M_NONFATAL, "%s: \"%ls\" registry value is not string (type
%u)",
+ __FUNCTION__, szName, dwValueType);
return ERROR_UNSUPPORTED_TYPE;
}
}
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1672?usp=email
To unsubscribe, or for help writing mail filters, visit
http://gerrit.openvpn.net/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Ia688ec12e642de699811ced8668b40be9fbb6155
Gerrit-Change-Number: 1672
Gerrit-PatchSet: 1
Gerrit-Owner: flichtenheld <[email protected]>
Gerrit-Reviewer: plaisthos <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: plaisthos <[email protected]>
_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
