Attention is currently required from: plaisthos.
Hello plaisthos,
I'd like you to do a code review.
Please visit
http://gerrit.openvpn.net/c/openvpn/+/1676?usp=email
to review the following change.
Change subject: pool: Fix a potential NULL pointer de-reference in test code
......................................................................
pool: Fix a potential NULL pointer de-reference in test code
Identified by cppcheck. Probably has been a long time
since that code has been compiled, though.
Change-Id: I09ebbf6f3555dd68ce8d75bfa844ecac518a0cf2
Signed-off-by: Frank Lichtenheld <[email protected]>
---
M src/openvpn/pool.c
1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/76/1676/1
diff --git a/src/openvpn/pool.c b/src/openvpn/pool.c
index 15004c0..ff74e7c 100644
--- a/src/openvpn/pool.c
+++ b/src/openvpn/pool.c
@@ -757,7 +757,7 @@
break;
}
msg(M_INFO | M_NOPREFIX, "IFCONFIG_POOL TEST pass 1: l=%s r=%s cn=%s",
- print_in_addr_t(local, 0, &gc), print_in_addr_t(remote, 0, &gc),
cn);
+ print_in_addr_t(local, 0, &gc), print_in_addr_t(remote, 0, &gc),
cn ? cn : "[NULL]");
array[i] = h;
}
@@ -793,7 +793,7 @@
break;
}
msg(M_INFO | M_NOPREFIX, "IFCONFIG_POOL TEST pass 3: l=%s r=%s cn=%s",
- print_in_addr_t(local, 0, &gc), print_in_addr_t(remote, 0, &gc),
cn);
+ print_in_addr_t(local, 0, &gc), print_in_addr_t(remote, 0, &gc),
cn ? cn : "[NULL]");
array[i] = h;
}
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1676?usp=email
To unsubscribe, or for help writing mail filters, visit
http://gerrit.openvpn.net/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I09ebbf6f3555dd68ce8d75bfa844ecac518a0cf2
Gerrit-Change-Number: 1676
Gerrit-PatchSet: 1
Gerrit-Owner: flichtenheld <[email protected]>
Gerrit-Reviewer: plaisthos <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: plaisthos <[email protected]>
_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
