Attention is currently required from: flichtenheld, plaisthos.

cron2 has posted comments on this change by flichtenheld. ( 
http://gerrit.openvpn.net/c/openvpn/+/1675?usp=email )

Change subject: lladdr: Clean up code
......................................................................


Patch Set 3:

(1 comment)

File src/openvpn/lladdr.c:

http://gerrit.openvpn.net/c/openvpn/+/1675/comment/d122e12c_36579c0f?usp=email :
PS3, Line 38:     argv_printf(&argv, "%s %s ether %s", IFCONFIG_PATH, ifname, 
lladdr);
ah, here's the culprit... it defines `IFCONFIG_LLADDR_CMD` and then 
unconditionally puts `ether` on the command line ;-)



--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1675?usp=email
To unsubscribe, or for help writing mail filters, visit 
http://gerrit.openvpn.net/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Ibe7b3c17176c97a1cbb4d9cc87735b05e62c4f43
Gerrit-Change-Number: 1675
Gerrit-PatchSet: 3
Gerrit-Owner: flichtenheld <[email protected]>
Gerrit-Reviewer: cron2 <[email protected]>
Gerrit-Reviewer: plaisthos <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: plaisthos <[email protected]>
Gerrit-Attention: flichtenheld <[email protected]>
Gerrit-Comment-Date: Tue, 12 May 2026 15:27:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Reply via email to