Attention is currently required from: flichtenheld, plaisthos. cron2 has posted comments on this change by flichtenheld. ( http://gerrit.openvpn.net/c/openvpn/+/1675?usp=email )
Change subject: lladdr: Clean up code ...................................................................... Patch Set 4: Code-Review-1 (1 comment) File src/openvpn/lladdr.c: http://gerrit.openvpn.net/c/openvpn/+/1675/comment/4355900b_2379d2b6?usp=email : PS4, Line 31: #endif after testing, I would do a new round on this - basically, "lladdr" and "ether" are synonymous on FreeBSD and Darwin. OpenBSD insists on using `lladdr`, which should work fine (according to manpage) on FreeBSD and macOS too... so I would unify this to "lladdr" for those 3 platforms. (NetBSD would need `... link %s active`, so that needs an extra #ifdef anyway should we decide to add support for it) Solaris "ether" does something, but the resulting tap interface does not work properly (it sends out ARP requests with a wrong source address in the ARP header). So I would downgrade Solaris to "Sorry, but I don't know" - whoever wants this can bring it back in a working shape. -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1675?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: Ibe7b3c17176c97a1cbb4d9cc87735b05e62c4f43 Gerrit-Change-Number: 1675 Gerrit-PatchSet: 4 Gerrit-Owner: flichtenheld <[email protected]> Gerrit-Reviewer: cron2 <[email protected]> Gerrit-Reviewer: plaisthos <[email protected]> Gerrit-CC: openvpn-devel <[email protected]> Gerrit-Attention: plaisthos <[email protected]> Gerrit-Attention: flichtenheld <[email protected]> Gerrit-Comment-Date: Wed, 13 May 2026 08:39:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes
_______________________________________________ Openvpn-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openvpn-devel
