Attention is currently required from: flichtenheld.

plaisthos has posted comments on this change by plaisthos. ( 
http://gerrit.openvpn.net/c/openvpn/+/1727?usp=email )

Change subject: Add lookup of multi session by session id
......................................................................


Patch Set 5:

(2 comments)

File src/openvpn/sid_hash.h:

http://gerrit.openvpn.net/c/openvpn/+/1727/comment/710c4a27_8bb4a5f3?usp=email :
PS5, Line 59:     struct hash_element *he = multi_hash_sid_lookup(m, sid);
> ``` […]
yeah looks like the "just quickly inline the function" in last iteration was 
not a good or quick fix. I reverted that since it is different enough to not 
easily work that way.


http://gerrit.openvpn.net/c/openvpn/+/1727/comment/b4b7f9d6_c2a71540?usp=email :
PS5, Line 64:         ASSERT(hash_remove_fast(m->sid_hash, bucket, sid, hv));
> ``` […]
Done



--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1727?usp=email
To unsubscribe, or for help writing mail filters, visit 
http://gerrit.openvpn.net/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Idb59ecd119331b198792ad1379bec8600211651b
Gerrit-Change-Number: 1727
Gerrit-PatchSet: 5
Gerrit-Owner: plaisthos <[email protected]>
Gerrit-Reviewer: flichtenheld <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: flichtenheld <[email protected]>
Gerrit-Comment-Date: Mon, 20 Jul 2026 10:55:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: flichtenheld <[email protected]>
_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Reply via email to