Attention is currently required from: plaisthos. flichtenheld has posted comments on this change by plaisthos. ( http://gerrit.openvpn.net/c/openvpn/+/1837?usp=email )
Change subject: Reenable xmit_hold when using p2p tcp-server and tls-server ...................................................................... Patch Set 1: Code-Review-1 (8 comments) Patchset: PS1: commit message needs some work Commit Message: http://gerrit.openvpn.net/c/openvpn/+/1837/comment/65e0750c_ba449b7d?usp=email : PS1, Line 7: Reenable xmit_hold when using p2p tcp-server and tls-server spurious whitespace http://gerrit.openvpn.net/c/openvpn/+/1837/comment/b3c294dc_83cac3b1?usp=email : PS1, Line 9: Commit 619c3e9 changed the logic to only enable xmit_hold only doubled "only" http://gerrit.openvpn.net/c/openvpn/+/1837/comment/6bcaee95_047866ff?usp=email : PS1, Line 10: when c->mode is CM_CHILD_TOP. This works for the --mode server Remove "the" http://gerrit.openvpn.net/c/openvpn/+/1837/comment/2ccd8a54_df0b8463?usp=email : PS1, Line 11: was probably done to allow this to properly work when the server "and was" ? http://gerrit.openvpn.net/c/openvpn/+/1837/comment/e3fdbf8d_5bee3754?usp=email : PS1, Line 12: is listening on multiple sockets and options->ce.proto cannot be missing word after "be". "used"? http://gerrit.openvpn.net/c/openvpn/+/1837/comment/52ba6361_4ae9b15d?usp=email : PS1, Line 15: Restore the logic for p2p logic to avoid both sides starting sending doubled "logic" http://gerrit.openvpn.net/c/openvpn/+/1837/comment/89cc92bb_6bfd6e27?usp=email : PS1, Line 16: reset at the same time. "resets" -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1837?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I728067ef08481c87c7b6918c88ebcaeeec466534 Gerrit-Change-Number: 1837 Gerrit-PatchSet: 1 Gerrit-Owner: plaisthos <[email protected]> Gerrit-Reviewer: flichtenheld <[email protected]> Gerrit-CC: openvpn-devel <[email protected]> Gerrit-Attention: plaisthos <[email protected]> Gerrit-Comment-Date: Wed, 05 Aug 2026 13:33:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes
_______________________________________________ Openvpn-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openvpn-devel
