Attention is currently required from: flichtenheld. plaisthos has posted comments on this change by plaisthos. ( http://gerrit.openvpn.net/c/openvpn/+/1837?usp=email )
Change subject: Reenable xmit_hold when using p2p tcp-server and tls-server ...................................................................... Patch Set 1: (7 comments) Commit Message: http://gerrit.openvpn.net/c/openvpn/+/1837/comment/238d7783_0128ca67?usp=email : PS1, Line 7: Reenable xmit_hold when using p2p tcp-server and tls-server > spurious whitespace Done http://gerrit.openvpn.net/c/openvpn/+/1837/comment/51d08ab2_e9cfffc5?usp=email : PS1, Line 9: Commit 619c3e9 changed the logic to only enable xmit_hold only > doubled "only" Done http://gerrit.openvpn.net/c/openvpn/+/1837/comment/321fc139_9c01d6f5?usp=email : PS1, Line 10: when c->mode is CM_CHILD_TOP. This works for the --mode server > Remove "the" Done http://gerrit.openvpn.net/c/openvpn/+/1837/comment/fe050e83_ab706fd1?usp=email : PS1, Line 11: was probably done to allow this to properly work when the server > "and was" ? Done http://gerrit.openvpn.net/c/openvpn/+/1837/comment/f162c472_acb77db8?usp=email : PS1, Line 12: is listening on multiple sockets and options->ce.proto cannot be > missing word after "be". […] Done http://gerrit.openvpn.net/c/openvpn/+/1837/comment/6d65ee1e_58880f3f?usp=email : PS1, Line 15: Restore the logic for p2p logic to avoid both sides starting sending > doubled "logic" Done http://gerrit.openvpn.net/c/openvpn/+/1837/comment/3d426e9f_ea3bdeba?usp=email : PS1, Line 16: reset at the same time. > "resets" Done -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1837?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I728067ef08481c87c7b6918c88ebcaeeec466534 Gerrit-Change-Number: 1837 Gerrit-PatchSet: 1 Gerrit-Owner: plaisthos <[email protected]> Gerrit-Reviewer: flichtenheld <[email protected]> Gerrit-CC: openvpn-devel <[email protected]> Gerrit-Attention: flichtenheld <[email protected]> Gerrit-Comment-Date: Wed, 05 Aug 2026 15:09:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: flichtenheld <[email protected]>
_______________________________________________ Openvpn-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openvpn-devel
