Attention is currently required from: d12fk, plaisthos. razvanc has posted comments on this change by d12fk. ( http://gerrit.openvpn.net/c/openvpn/+/1861?usp=email )
Change subject: openvpnserv: fix log lines format string ...................................................................... Patch Set 1: (1 comment) File src/openvpnserv/interactive.c: http://gerrit.openvpn.net/c/openvpn/+/1861/comment/8c4d92b3_b1aef36b?usp=email : PS1, Line 1228: MsgToEventLog(M_ERR, L"%S: failed to convert itf alias '%s'", __func__, wide_name); This is probably correct and Windows can deal with it, but `wide_name` _can_ be `NULL` here (especially in allocator failure situations - `ERROR_OUTOFMEMORY`). So whether this patch is correct or not depends on how safe it is to pass `NULL` into `%s` here. -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1861?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: Iec392a47123d618c0dbc3a5241c39da4ac83d880 Gerrit-Change-Number: 1861 Gerrit-PatchSet: 1 Gerrit-Owner: d12fk <[email protected]> Gerrit-Reviewer: plaisthos <[email protected]> Gerrit-CC: openvpn-devel <[email protected]> Gerrit-CC: razvanc <[email protected]> Gerrit-Attention: plaisthos <[email protected]> Gerrit-Attention: d12fk <[email protected]> Gerrit-Comment-Date: Mon, 24 Aug 2026 08:50:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No
_______________________________________________ Openvpn-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openvpn-devel
