Attention is currently required from: plaisthos, razvanc.

d12fk has posted comments on this change by d12fk. ( 
http://gerrit.openvpn.net/c/openvpn/+/1861?usp=email )

Change subject: openvpnserv: fix log lines format string
......................................................................


Patch Set 1:

(1 comment)

File src/openvpnserv/interactive.c:

http://gerrit.openvpn.net/c/openvpn/+/1861/comment/7669db36_0e096c45?usp=email :
PS1, Line 1228:         MsgToEventLog(M_ERR, L"%S: failed to convert itf alias 
'%s'", __func__, wide_name);
> This is probably correct and Windows can deal with it, but `wide_name` _can_ 
> be `NULL` here (especia […]
Yeah, spent a thought on this, but vswprintf() (called in MsgToEventLog) 
handles NULL arguments and prints "(null)". Only the _s version of the 
functions halts the program.



--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1861?usp=email
To unsubscribe, or for help writing mail filters, visit 
http://gerrit.openvpn.net/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Iec392a47123d618c0dbc3a5241c39da4ac83d880
Gerrit-Change-Number: 1861
Gerrit-PatchSet: 1
Gerrit-Owner: d12fk <[email protected]>
Gerrit-Reviewer: plaisthos <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-CC: razvanc <[email protected]>
Gerrit-Attention: plaisthos <[email protected]>
Gerrit-Attention: razvanc <[email protected]>
Gerrit-Comment-Date: Mon, 24 Aug 2026 15:28:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: razvanc <[email protected]>
_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Reply via email to