Attention is currently required from: plaisthos, razvanc. flichtenheld has posted comments on this change by flichtenheld. ( http://gerrit.openvpn.net/c/openvpn/+/1592?usp=email )
Change subject: configure: Add --enable-code-coverage ...................................................................... Patch Set 5: (3 comments) File .gitignore: http://gerrit.openvpn.net/c/openvpn/+/1592/comment/4eee09ac_cb606273?usp=email : PS4, Line 4: *.gcno > Should we also include `*.gcov`, `*-coverage. […] Why *.gcov? We do not seem to generate any such files? File configure.ac: http://gerrit.openvpn.net/c/openvpn/+/1592/comment/ea5961ef_07c90e9d?usp=email : PS4, Line 1243: [CFLAGS="`echo $CFLAGS | $SED -e 's/-O[s0-9]\\?//g'`"] > This actually only matches numerical optimization levels (like `O3`, etc. […] Done File src/openvpn/Makefile.am: http://gerrit.openvpn.net/c/openvpn/+/1592/comment/a6d383dd_1342d5d0?usp=email : PS4, Line 38: AM_LIBS = $(CODE_COVERAGE_LIBS) > Is `AM_LIBS` a thing? I can't find it in the Automake docs and it doesn't > seem to be referenced anyw […] Hmm, I assume I meant AM_LDFLAGS. It doesn't really matter since we include AM_CFLAGS in LINK as well, but will fix. -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1592?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I79b2dc4a550b1c5068a45407976b0dfc2f765b33 Gerrit-Change-Number: 1592 Gerrit-PatchSet: 5 Gerrit-Owner: flichtenheld <[email protected]> Gerrit-Reviewer: plaisthos <[email protected]> Gerrit-Reviewer: razvanc <[email protected]> Gerrit-CC: openvpn-devel <[email protected]> Gerrit-Attention: plaisthos <[email protected]> Gerrit-Attention: razvanc <[email protected]> Gerrit-Comment-Date: Mon, 24 Aug 2026 15:06:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: razvanc <[email protected]>
_______________________________________________ Openvpn-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openvpn-devel
